Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Sample type and member access levels #491

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

CalebRas
Copy link
Collaborator

@CalebRas CalebRas commented Aug 7, 2024

Description

This PR updates the access levels of types and members used by samples to make them more encapsulated. This was done to:

  • Prevent types and members being reused in other samples. (Samples should be stand alone to allow users to copy and paste them, see related comment.)
  • Prevent existing declarations interfering with new ones. (E.g., the internal Model used by Edit geodatabase with transactions was preventing any new samples from implementing their own file-private Model.)

Overview of changes (corresponding to a commit):

  • Make types file-private or nested (or both).
  • Make extensions private were possible.
  • Make sample view members (properties, methods, & nested types) private were possible.

Linked Issue(s)

Closes #375.

How To Test

There are no functionality changes in this PR so ensuring the project builds should be sufficient.

@CalebRas CalebRas self-assigned this Aug 7, 2024
@CalebRas CalebRas linked an issue Aug 7, 2024 that may be closed by this pull request
@CalebRas CalebRas requested review from a team, philium and des12437 and removed request for a team August 7, 2024 22:33
des12437
des12437 previously approved these changes Aug 7, 2024
@CalebRas CalebRas dismissed stale reviews from philium and des12437 via 19741fb August 8, 2024 17:18
@CalebRas CalebRas requested a review from philium August 8, 2024 17:18
@CalebRas CalebRas requested a review from des12437 August 8, 2024 19:02
@CalebRas CalebRas merged commit 7e05dc8 into v.next Aug 8, 2024
1 check passed
@CalebRas CalebRas deleted the Caleb/Fix-SampleAccessLevels branch August 8, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examine access levels for all sample types
3 participants