Akaday patch 1 #11
Closed
Akaday patch 1 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updates (KhronosGroup#5780) Bumps the github-actions group with 3 updates in the / directory: [lukka/get-cmake](https://github.com/lukka/get-cmake), [actions/upload-artifact](https://github.com/actions/upload-artifact) and [github/codeql-action](https://github.com/github/codeql-action). Updates `lukka/get-cmake` from 3.30.2 to 3.30.3 - [Release notes](https://github.com/lukka/get-cmake/releases) - [Commits](lukka/get-cmake@a70f1cf...070a050) Updates `actions/upload-artifact` from 4.3.6 to 4.4.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@834a144...5076954) Updates `github/codeql-action` from 3.26.4 to 3.26.6 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f0f3afe...4dd1613) --- updated-dependencies: - dependency-name: lukka/get-cmake dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oup#5773) * Roll external/googletest/ ff233bdd4..0953a17a4 (1 commit) google/googletest@ff233bd...0953a17 Created with: roll-dep external/googletest * Roll external/abseil_cpp/ fd7713cb9..e64dd622d (10 commits) abseil/abseil-cpp@fd7713c...e64dd62 Created with: roll-dep external/abseil_cpp * Roll external/spirv-headers/ 69ab0f32d..efb6b4099 (2 commits) KhronosGroup/SPIRV-Headers@69ab0f3...efb6b40 Created with: roll-dep external/spirv-headers --------- Co-authored-by: GitHub Actions[bot] <>
…Group#5785) This reverts commit 70ad4da. Contributes to KhronosGroup#5781 SPIR WG 2024-09-04: decision to relax validation requirement in the spec.
…hronosGroup#5758) FORCED_BUILD_VERSION_DESCRIPTION envvar can be used to force a version description instead of resorting to git describe which can change for a given commit if multiple lightweight commits point ot it. Signed-off-by: Yoann Congal <[email protected]>
…oup#5782) abseil/abseil-cpp@e64dd62...f7f3168 Created with: roll-dep external/abseil_cpp Co-authored-by: GitHub Actions[bot] <>
This pass allows to re-assign offset layout decorations to tightly pack a struct according to its packing rules.
…d instructions (KhronosGroup#5788) * [SPV_KHR_untyped_pointers] Fix verification of vload/vstore OpenCL.std instructions Allow `p` to be untyped pointer. ``` operand must be a pointer(p1, ...).If it is a typed pointer, it must point to data types. ``` https://htmlpreview.github.io/?https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_untyped_pointers.html#_modifications_to_the_opencl_std_extended_instruction_set * relax printf check as well
Fixes KhronosGroup#5781 * Requires all image operands to match except for depth between operand and result
* Fix capability trimming tests to use KHR names for compute derivatives
…oup#5787) abseil/abseil-cpp@f7f3168...67d1260 Created with: roll-dep external/abseil_cpp Co-authored-by: GitHub Actions[bot] <>
…hronosGroup#5800) Fixes KhronosGroup#5784 * Rules only apply to structurally reachable blocks
* spirv-opt: fix crash in function declarations Function declarations contain no blocks, so bail before segfaulting in function optimization passes that operate on blocks. Fixes KhronosGroup#5795 * spirv-opt: add test for optimizing declarations
…oup#5801) abseil/abseil-cpp@67d1260...1d4466e Created with: roll-dep external/abseil_cpp Co-authored-by: GitHub Actions[bot] <>
…5805) Using the locale takes a mutex deep in the C++ library. Avoid this on hot compilation paths, e.g. in the validator. Fixed: KhronosGroup#5802
…oup#5806) abseil/abseil-cpp@1d4466e...f7c22f5 Created with: roll-dep external/abseil_cpp Co-authored-by: GitHub Actions[bot] <>
…onosGroup#5803) The code converting the global to local was generating an extra operand that was incorrect. Fixed the code, and added a unit test. Fixes KhronosGroup#5776
…hronosGroup#5808) Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action). Updates `github/codeql-action` from 3.26.6 to 3.26.7 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4dd1613...8214744) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Roll external/googletest/ 0953a17a4..6dae7eb4a (1 commit) google/googletest@0953a17...6dae7eb Created with: roll-dep external/googletest * Roll external/abseil_cpp/ f7c22f52a..0df567400 (10 commits) abseil/abseil-cpp@f7c22f5...0df5674 Created with: roll-dep external/abseil_cpp --------- Co-authored-by: GitHub Actions[bot] <>
…ns (KhronosGroup#5810) Allow `p` to be untyped pointer for `fract`, `frexp`, `lgamma_r`, `modf`, `remquo`, and `sincos`. ``` operand must be a pointer(p1, ...).If it is a typed pointer, it must point to data types. ``` https://htmlpreview.github.io/?https://github.com/KhronosGroup/SPIRV-Registry/blob/main/extensions/KHR/SPV_KHR_untyped_pointers.html#_modifications_to_the_opencl_std_extended_instruction_set
Ensure that the validator rejects stores to objects of types `OpTypeImage`, `OpTypeSampler`, `OpTypeSampledImage`, `OpTypeAccelerationStructureKHR`, and arrays of these types, according to `VUID-StandaloneSpirv-OpTypeImage-06924`. Guard the check behind the before_hlsl_legalization option, as sometimes we may have temporaries or local variables that are expected to get optimized away. Fixes KhronosGroup#4796 Change-Id: Ie035c01c5f94e7bdfc16b5c6c85705f302b7bda3 Signed-off-by: Sven van Haastregt <[email protected]>
…oup#5812) abseil/abseil-cpp@0df5674...c0b9bd0 Created with: roll-dep external/abseil_cpp Co-authored-by: GitHub Actions[bot] <>
…hronosGroup#5813) Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action). Updates `github/codeql-action` from 3.26.7 to 3.26.8 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@8214744...294a9d9) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Fixes KhronosGroup#5819 * Allow multiple levels of arrays in a variable with component decoration
* Add support for SPV_KHR_compute_shader_derivative * Update tests for SPV_KHR_compute_shader_derivatives --------- Co-authored-by: MagicPoncho <[email protected]>
…oup#5818) * Roll external/abseil_cpp/ c0b9bd08e..ba5fd0979 (2 commits) abseil/abseil-cpp@c0b9bd0...ba5fd09 Created with: roll-dep external/abseil_cpp * Roll external/spirv-headers/ 2a9b6f951..ec59c77a3 (2 commits) KhronosGroup/SPIRV-Headers@2a9b6f9...ec59c77 Created with: roll-dep external/spirv-headers --------- Co-authored-by: GitHub Actions[bot] <>
…updates (KhronosGroup#5825) Bumps the github-actions group with 2 updates in the / directory: [actions/checkout](https://github.com/actions/checkout) and [github/codeql-action](https://github.com/github/codeql-action). Updates `actions/checkout` from 4.1.7 to 4.2.0 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@692973e...d632683) Updates `github/codeql-action` from 3.26.8 to 3.26.9 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@294a9d9...461ef6c) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor dependency-group: github-actions - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…onosGroup#5826) Bumps [rollup](https://github.com/rollup/rollup) from 3.23.0 to 3.29.5. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v3.23.0...v3.29.5) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
We cannot apply the negate to an operand of an OpUDiv instead of it result. This is because the operands of the OpUDiv are interpreted as unsigned. We stop the optimizer from doing that. There were no tests for distributing a negate into OpIMul, OpSDiv, and OpUDiv. Tests are added for all of these. Fixes KhronosGroup#5822
The GLSL 450 InterpolateAt* instructions should be treated as a load by dead code elimination. This is part of microsoft/DirectXShaderCompiler#3649.
…up#5828) abseil/abseil-cpp@ba5fd09...482ca0b Created with: roll-dep external/abseil_cpp Co-authored-by: GitHub Actions[bot] <>
…hronosGroup#5827) Adds support for `InterpolateAtCentroid`, `InterpolateAtSample`, and `InterpolateAtOffset` to the copy propagate arrays pass, as well as propagating pointers with the `Input` storage class. Also handles situations where variables should be propagated in an order different than the order that they are declared in the source.
…up#5829) * Roll external/googletest/ 6dae7eb4a..a1e255a58 (1 commit) google/googletest@6dae7eb...a1e255a Created with: roll-dep external/googletest * Roll external/abseil_cpp/ 482ca0b9d..c6b27359c (1 commit) abseil/abseil-cpp@482ca0b...c6b2735 Created with: roll-dep external/abseil_cpp --------- Co-authored-by: GitHub Actions[bot] <>
…hronosGroup#5831) Bumps the github-actions group with 1 update: [github/codeql-action](https://github.com/github/codeql-action). Updates `github/codeql-action` from 3.26.9 to 3.26.10 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@461ef6c...e2b3eaf) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch dependency-group: github-actions ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…5836) The grammar does track required capabilities for extended instruction set operations, so we just need to look them up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.