This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Add new Common and signalling libs and rewrite Cirrus (now Wilbur) to use them #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mcottontensor
commented
Feb 28, 2024
mcottontensor
commented
- Added Common library
- Added Signalling library
- Removed Cirrus
- Added Wilbur
…ck and forth on logging. A bunch of cleanup.
…Now theyre more managed by the registry.
…operly report the signalling version. Tweaked cli arguments.
…n the new server.
…the signalling lib into Signalling.
…ker and https changes.
…m revision to branch
… us to specify which branch.
…ence in frontend. Cleaned up some broken windows scripts for wilbur. More will need to be updated.
lukehb
changed the title
lukehb
suggested changes
Feb 28, 2024
| IF "%DEFAULT_STUN%"=="1" ( | ||
| set STUN_SERVER=stun.l.google.com:19302 | ||
| ) | ||
| FOR /f %%A IN ('powershell -command "(Test-Connection -ComputerName (hostname) -Count 1 | Select IPV4Address).IPV4Address.IPAddressToString"') DO set LOCAL_IP=%%A |
There was a problem hiding this comment.
Can we remove dep on powershell by doing? Does that work?
@Echo off
for /f "tokens=1* delims=: " %%A in (
'nslookup myip.opendns.com. resolver1.opendns.com 2^>NUL^|find "Address:"'
) Do set ExtIP=%%B
Echo External IP is : %ExtIP%There was a problem hiding this comment.
We could probably work something out, but we're already using powershell for the ipify remote ip lookup.
| IF NOT "%TURN_USER%"=="" ( | ||
| IF NOT "%TURN_PASS%"=="" ( | ||
| pushd %SCRIPT_DIR%coturn\ | ||
| IF "%1"=="bg" ( |
There was a problem hiding this comment.
Does it make sense for bg to be in the help commands?
There was a problem hiding this comment.
No because it's not a cli option but more of an option of the function being called
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.