Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set nNonce to Null in CoinsView #1008

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

set nNonce to Null in CoinsView #1008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/coins.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,10 @@ static inline CCoinsMapKey native_key(const COutPoint& outpoint) {

CCoinsMap::iterator CCoinsViewCache::FetchCoin(const COutPoint &outpoint) const {
CCoinsMap::iterator it = cacheCoins.find(native_key(outpoint));
if (it != cacheCoins.end())
if (it != cacheCoins.end()) {
assert(it->second.coin.out.nNonce.IsNull());
return it;
}
Coin tmp;
if (!base->GetCoin(outpoint, tmp))
return cacheCoins.end();
Expand All @@ -72,6 +74,7 @@ bool CCoinsViewCache::GetCoin(const COutPoint &outpoint, Coin &coin) const {
CCoinsMap::const_iterator it = FetchCoin(outpoint);
if (it != cacheCoins.end()) {
coin = it->second.coin;
assert(coin.out.nNonce.IsNull());
return !coin.IsSpent();
}
return false;
Expand Down Expand Up @@ -119,7 +122,9 @@ void AddCoins(CCoinsViewCache& cache, const CTransaction &tx, int nHeight, bool
bool overwrite = check_for_overwrite ? cache.HaveCoin(COutPoint(txid, i)) : fCoinbase;
// Coinbase transactions can always be overwritten, in order to correctly
// deal with the pre-BIP30 occurrences of duplicate coinbase transactions.
cache.AddCoin(COutPoint(txid, i), Coin(tx.vout[i], nHeight, fCoinbase), overwrite);
Coin new_coin(tx.vout[i], nHeight, fCoinbase);
new_coin.out.nNonce.SetNull();
cache.AddCoin(COutPoint(txid, i), std::move(new_coin), overwrite);
}
}

Expand Down