Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fsm config load #698

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

add fsm config load #698

wants to merge 5 commits into from

Conversation

Yunxe
Copy link
Contributor

@Yunxe Yunxe commented Aug 30, 2023

What this PR does / why we need it:
add fsm config load to deviceshifubase && complete relative unit test
Will this PR make the community happier?
yes
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

How is this PR tested

  • unit test
  • e2e test
  • other (please specify)

Special notes for your reviewer:

Release note:

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.11% 🎉

Comparison is base (ae036da) 54.76% compared to head (6351879) 54.88%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
+ Coverage   54.76%   54.88%   +0.11%     
==========================================
  Files          23       23              
  Lines        2277     2283       +6     
==========================================
+ Hits         1247     1253       +6     
  Misses        914      914              
  Partials      116      116              
Files Changed Coverage Δ
pkg/deviceshifu/deviceshifubase/deviceshifubase.go 57.93% <ø> (ø)
...iceshifu/deviceshifubase/deviceshifubase_config.go 65.16% <33.33%> (-1.12%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

next_state: red
forbid:
- go
startingState: red
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an empty line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants