Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radio): fix GV calculation and menu navigation in weight/offset/expo fields. #5564

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(radio): fix GV calculation and menu navigation in weight/offset/expo fields. #5564

wants to merge 1 commit into from
+31 −25

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Sep 26, 2024

Fixes a number of issues from the changes that allow any source to be used for weight/offset/expo fields.

  • Negative GV values are not calculated correctly (all radios).
  • After changing field to a source value, the field reverts to a constant value (b&w only).
  • Cannot change source value properly using roller, when an Input is selected for the field (b&w only).
  • When selecting Inputs as the source type (using long press on the field), the second input is selected instead of the first (b&w only).

@philmoz philmoz added color Related generally to color LCD radios B&W Related generally to black and white LCD radios bug/regression ↩️ A new version of EdgeTX broke something labels Sep 26, 2024
@philmoz philmoz added this to the 2.11 milestone Sep 26, 2024
@wimalopaan wimalopaan mentioned this pull request Sep 26, 2024
Closed
1 task
Fix issues with B&W menu navigation for weight/offset/expo fields. Fi…
1d4956f 
…x calculated value when using negative GV in input or mix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
B&W Related generally to black and white LCD radios bug/regression ↩️ A new version of EdgeTX broke something color Related generally to color LCD radios
Projects
None yet
Milestone
2.11
Development

Successfully merging this pull request may close these issues.
1 participant
@philmoz