Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ResultSet slicing #104

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow ResultSet slicing #104

wants to merge 2 commits into from

Conversation

hoetmaaiers
Copy link

No description provided.

@bouweandela
Copy link
Collaborator

Thanks for taking the time to contribute! Could you please remove the whitespace from line 48?

A unit test would be much appreciated if you have the time.

@hoetmaaiers
Copy link
Author

The whitespace is removed, the unit test won't be for anytime soon...

@bouweandela
Copy link
Collaborator

Thanks! The test failure appears to be unrelated to this pull request.

@valeriupredoi
Copy link
Collaborator

many thanks folks, I'm "fixing" the test failure in #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoetmaaiers @bouweandela @valeriupredoi