read in all possible constituents from file, not just build-time ones #301
+1,461
−1,092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusbaume
reviewed
Sep 23, 2024
| @@ -550,6 +573,17 @@ def write_ic_arrays(outfile, ic_name_dict, ic_max_len, | |||
| #Write line to file: | |||
| outfile.write(log_arr_str, 2) | |||
| # end for | |||
| for var_num, var_name in enumerate(registry_constituents): | |||
There was a problem hiding this comment.
Do we need to reset arr_suffix to ", &" before this loop starts?
| @@ -579,6 +612,16 @@ def write_ic_arrays(outfile, ic_name_dict, ic_max_len, | |||
| #Write line to file: | |||
| outfile.write(log_arr_str, 2) | |||
| # end for | |||
| for var_num, varname in enumerate(registry_constituents): | |||
There was a problem hiding this comment.
Same question here. Do we need to reset arr_suffix to ", &" before this loop starts?
| outfile.write("write(iulog,*) 'Constituent ', trim(std_name), ' initialized to default value: ', constituent_default_value", 6) | ||
| outfile.write("end if", 5) | ||
| outfile.write("else", 4) | ||
| outfile.write("field_data_ptr(:,:,constituent_idx) = 0._kind_phys", 5) |
There was a problem hiding this comment.
Should we initialize to the constituent minimum value instead of zero?
| outfile.write("var_found = .false.", 3) | ||
| outfile.comment("Check if constituent standard name in registered SIMA standard names list:", 3) | ||
| outfile.write("call const_props(constituent_idx)%standard_name(std_name)", 3) | ||
| outfile.write("if(any(phys_var_stdnames == trim(std_name))) then", 3) |
There was a problem hiding this comment.
Are there going to be any issues with the fact that the phys_var_stdnames entries aren't trimmed here? The same question holds for the other if(any(phys_var_stdnames check below as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag name (required for release branches):
Originator(s): peverwhee
Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):
Describe any changes made to build system:
M cime_config/cam_autogen.py
M cime_config/cam_build_cache.py
M cime_config/cam_config.py
Describe any changes made to the namelist: None
List any changes to the defaults for the input datasets (e.g. boundary datasets): None
List all files eliminated and why: None
List all files added and what they do: None
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)M src/data/generate_registry_data.py
M src/data/write_init_files.py
M test/unit/test_*.py
If there are new failures (compare to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: