Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifying description scanning phase. #291

Merged

Conversation

mwaxmonsky
Copy link
Collaborator

@mwaxmonsky mwaxmonsky commented Aug 22, 2024

Reducing description scanning to one step and leveraging list intersections to create list of pull requests and issues to close.

closes #279

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mwaxmonsky!

@mwaxmonsky mwaxmonsky marked this pull request as ready for review August 22, 2024 21:36
@mwaxmonsky
Copy link
Collaborator Author

Sorry @nusbaume and @peverwhee. Had a small bug in my list intersection logic. Should be fixed now.

@mwaxmonsky mwaxmonsky merged commit 4663589 into ESCOMP:development Aug 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

3 participants