Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade MPAS to version 8.2.1 #288

Conversation

kuanchihwang
Copy link
Collaborator

Currently, CAM-SIMA uses MPAS at commit ed6f8e39ec0a811b6d079ca0fc6f9fb6e30bad23, which is half way between MPAS versions 8.0.1 and 8.1.0.

This PR upgrades MPAS to version 8.2.1, which was released on August 7, 2024.

  • MPAS dynamical core and its subdriver in CAM-SIMA now support MPI Fortran 2008 interface through the mpi_f08 module. It can be enabled by defining the MPAS_USE_MPI_F08 macro in CPPFLAGS.
  • The log file (e.g., log.atmosphere.0000.out) produced by MPAS dynamical core now correctly indicates its git version string. Before, it would always show "N/A" in the log, which is not very helpful. Now, if the git submodule of MPAS is aligned at a tag, it will just show the tag name (e.g., "v8.2.1"). Otherwise, if the git submodule of MPAS is not aligned at a tag, it will show the nearest tag name, the number of commits after that tag and the abbreviated commit hash (e.g., "v8.0.1-54-ged6f8e39e").
  • Tidy up the build directory of MPAS dynamical core.

Additionally, MPI Fortran 2008 interface is now supported through the `mpi_f08`
module. It can be enabled by defining the `MPAS_USE_MPI_F08` macro in
`CPPFLAGS`.
Before, it would always show "N/A" in the log, which is not very helpful.

Now, if the git submodule of MPAS is aligned at a tag, it will just show the tag
name (e.g., "v8.2.1"). Otherwise, if the git submodule of MPAS is not aligned at
a tag, it will show the nearest tag name, the number of commits after that tag
and the abbreviated commit hash (e.g., "v8.0.1-54-ged6f8e39e").
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @kuanchihwang!

Copy link
Collaborator

@mgduda mgduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps no real changes are needed, but just a question about the need for the /= operator from the mpi_f08 module.

src/dynamics/mpas/driver/dyn_mpas_subdriver.F90 Outdated Show resolved Hide resolved
@mgduda mgduda self-requested a review September 9, 2024 20:18
@kuanchihwang kuanchihwang merged commit 6b643f6 into ESCOMP:development Sep 9, 2024
8 checks passed
@kuanchihwang kuanchihwang deleted the staging/upgrade-mpas-to-version-821 branch September 9, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants