Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git-fleximod ci test #281

Merged
merged 8 commits into from
Aug 12, 2024
Merged

Conversation

peverwhee
Copy link
Collaborator

@peverwhee peverwhee commented Jul 25, 2024

Updates git-fleximod to v8.4 and adds the git-fleximod github workflow.

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the boundary datasets: N/A

Describe any substantial timing or memory changes: N/A

Code reviewed by: cacraigucar, mwaxmonsky, nusbaume

List all existing files that have been modified, old files eliminated, new files added and describe the changes:

A .github/workflows/fleximod_test.yaml

derecho/intel/aux_cam: all tests pass
derecho/gnu/aux_cam: all tests pass

Summarize any changes to answers, i.e.,

what code configurations: N/A
what platforms/compilers: N/A
nature of change (roundoff; larger than roundoff but same climate; new climate): N/A

@peverwhee peverwhee marked this pull request as draft July 25, 2024 16:41
@peverwhee peverwhee marked this pull request as ready for review July 25, 2024 19:18
Copy link
Collaborator

@mwaxmonsky mwaxmonsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @peverwhee! Just one minor comment but nothing that should hold this up.

.github/workflows/fleximod_test.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be identical to what we brought into ESCOMP/CAM, so I am approving this. I figure if there are any issues, they would show up when it is committed.

@peverwhee peverwhee requested a review from nusbaume August 9, 2024 18:25
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some text to the new CAM-SIMA developer documentation that describes (or includes a link to a description of) these tests? That way we can point developers to something if the tests fail.

@peverwhee
Copy link
Collaborator Author

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the documentation! Just had a couple more suggestions.

.github/workflows/fleximod_test.yaml Outdated Show resolved Hide resolved
.github/workflows/fleximod_test.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. Thanks @peverwhee!

@peverwhee peverwhee merged commit 376367e into ESCOMP:development Aug 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants