Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find_input_name_idx bug #280

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

peverwhee
Copy link
Collaborator

@peverwhee peverwhee commented Jul 23, 2024

Resets find_input_name_idx to no_exist_idx after it is modified by const_get_index. Fixes the bug resulted in variables getting a huge <0 index value instead of -1, which caused an error in physics_read_data.

closes #237

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the boundary datasets: N/A

Describe any substantial timing or memory changes: N/A

Code reviewed by: nusbaume, mwaxmonsky

List all existing files that have been modified, old files eliminated, new files added and describe the changes:

M src/physics/utils/physics_data.F90

  • Reset find_input_name_idx to no_exist_idx after call to const_get_index

M cime_config/config_component.xml

  • No longer include chemistry linked libs by default

If there were any failures reported from running test_driver.sh on any test
platform, and check that these failures have been OK'd by the gatekeeper,
then copy the lines from the td.*.status files for the failed tests to the
appropriate machine below. All failed tests must be justified.

derecho/intel/aux_cam
derecho/gnu/aux_cam

All tests pass.

Summarize any changes to answers, i.e.,

what code configurations: N/A
what platforms/compilers: N/A
nature of change (roundoff; larger than roundoff but same climate; new climate): N/A

@peverwhee peverwhee merged commit 7a8c70b into ESCOMP:development Jul 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants