Skip to content

Commit

Permalink
Address reviewer comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
nusbaume committed Aug 20, 2024
1 parent 912774c commit ba0a966
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/scripts/branch_pr_issue_closer.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def _main_prog():

#If pull request has not been merged, then exit script:
if not merged_pull.merged:
endmsg = f"Pull request associated with commit:\n{trigger_sha}\n"
endmsg = f"Pull request #{pr_num} associated with commit:\n{trigger_sha}\n"
endmsg += "was not actually merged, so the script will not close anything."
end_script(endmsg)

Expand All @@ -156,7 +156,7 @@ def _main_prog():

#If PR was to default branch, then exit script (as github will handle it automatically):
if merged_branch == default_branch:
endmsg = "Pull request was merged into default repo branch. "
endmsg = f"Pull request #{pr_num} was merged into default repo branch. "
endmsg += "Thus issue is closed automatically"
end_script(endmsg)

Expand Down Expand Up @@ -201,7 +201,8 @@ def _main_prog():
#If at least one keyword is found, then determine location of every keyword instance:
word_matches = keyword_pattern.finditer(pr_msg_lower)
else:
endmsg = "Pull request was merged without using any of the keywords. Thus there are no issues to close."
endmsg = f"Pull request #{pr_num} was merged without using any of the keywords. "
endmsg += "Thus there are no issues to close."
end_script(endmsg)

#++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Expand Down

0 comments on commit ba0a966

Please sign in to comment.