Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use screen lifecycle based on #637 #825

Open
wants to merge 3 commits into
base: add-dfm
Choose a base branch
from
Open

Use screen lifecycle based on #637 #825

wants to merge 3 commits into from

Conversation

takahirom
Copy link
Member

jmatsu
jmatsu reviewed Feb 11, 2019
View reviewed changes
...nt/androidcomponent/src/main/java/io/github/droidkaigi/confsched2019/widget/PageViewModel.kt Outdated

import androidx.lifecycle.ViewModel

class PageViewModel : ViewModel() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it enough if ViewModel extends LifecycleOwner directly? 🤔

@jmatsu-bot
Copy link
Collaborator

Asserted successfully. 💯

Generated by 🚫 Danger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmatsu jmatsu jmatsu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@takahirom @jmatsu-bot @jmatsu