Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX : v20 pdf space lost with images eratosthene #31298

Open
wants to merge 3 commits into
base: 20.0
Choose a base branch
from

Conversation

thersane-john
Copy link
Contributor

@thersane-john thersane-john commented Oct 7, 2024

Need PR #31273 to be merged before

FIX pdf space lost with images on eratosthene PDF

like #31273

@eldy
Copy link
Member

eldy commented Oct 7, 2024

This seems to fix for some case but generate trouble on other.
Imagine the line that generate a break page with old code so output on second page and that, with new code, can be output on the first page. If this line is the last one of the proposal, then no break will be done.
But because ti is the last page, then the signature and the section for total is output. In such a case, this section overwrite the last line.
This is why the test to know if there is enough room was done using
($heightforfooter + $heightforfreetext + $heightforsignature + $heightforinfotot)

Do yo understand what i mean. Did you test this particular case ?

@eldy eldy added the Discussion Some questions or discussions are opened and wait answers of author or other people to be processed label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Some questions or discussions are opened and wait answers of author or other people to be processed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants