fix #258: update mysql password command #270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Jan 10, 2023
| @@ -1258,7 +1258,7 @@ if [[ "$mode" == "deploy" || "$mode" == "deployall" ]]; then | |||
| Q3a="SET PASSWORD FOR '$dbusername'@'localhost' = PASSWORD('$dbpassword'); " | |||
| Q3b="SET PASSWORD FOR '$dbusername'@'%' = PASSWORD('$dbpassword'); " | |||
| else | |||
| Q3="UPDATE mysql.user SET Password=PASSWORD('$dbpassword') WHERE User='$dbusername'; " | |||
| Q3="SET PASSWORD FOR '$dbusername' = PASSWORD('$dbpassword')" | |||
There was a problem hiding this comment.
2 lines after, there is a test to overwrite the old string for mysql to the new one that is hte one you changed.
So you should not need this change.
This line is for mysql and just after we erase Q3 with value for mariadb
What is the result of command dpkg -l | grep mariadb on your deployment server ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the fix, sorry for the delay