Revert "Update flake-schemas to 0.1.3" #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3
Testing to see if this resolves an issue around reproducing outputs.
...yes.
Checking in the flake.lock seems to cause this to be unreliable. The corpus comparison test actually caught the unreliable resolution behavior, but the corpus was updated to match. In the future, the corpus shouldn't be updated: it should always evaluate identically.
Specifically, what I'm seeing is Nix will re-resolve all the flake.nix input URLs instead of reusing the flake.lock. This means flake-iter will build everything as if it wasn't locked at all, which is not the desirable behavior.