fix issue where an empty baseline file was being automatically created

DetachHead · Sep 30, 2024 · a7b51db · a7b51db
1 parent 0bc2989
commit a7b51db
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/pyright-internal/src/pyright.ts b/packages/pyright-internal/src/pyright.ts
@@ -475,8 +475,11 @@ const outputResults = (
         !filteredDiagnostics.map((fileWithDiagnostics) => fileWithDiagnostics.diagnostics.length).reduce(add, 0)
     ) {
         const previousBaseline = getBaselinedErrors(service.fs, rootDir);
-        const newBaseline = writeDiagnosticsToBaselineFile(service.fs, rootDir, results.diagnostics, false);
-        console.info(getBaselineSummaryMessage(rootDir, previousBaseline, newBaseline));
+        // don't write the baseline file if there wasn't one there already unless the user explicitly asked for it
+        if (args.writebaseline || Object.keys(previousBaseline.files).length) {
+            const newBaseline = writeDiagnosticsToBaselineFile(service.fs, rootDir, results.diagnostics, false);
+            console.info(getBaselineSummaryMessage(rootDir, previousBaseline, newBaseline));
+        }
     }
 
     const treatWarningsAsErrors = !!args.warnings;