Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component EXTERNAL_REFERENCES column mapping #944

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Oct 3, 2024

Description

Endpoint /vi/vulnerability/project/{uuid} uses @RegisterFieldMapping which is trying to map byte array into array of externalReferences causing an exception.
Fixed it by using @RegisterColumnMapping for external references.

Addressed Issue

NA

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@sahibamittal sahibamittal added the defect Something isn't working label Oct 3, 2024
@sahibamittal sahibamittal added this to the 5.6.0 milestone Oct 3, 2024
nscuro
nscuro previously approved these changes Oct 3, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 75.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6232195) 22017 18196 82.65%
Head commit (1fff791) 22021 (+4) 18199 (+3) 82.64% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#944) 4 3 75.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@sahibamittal sahibamittal merged commit 61847b3 into main Oct 3, 2024
9 checks passed
@sahibamittal sahibamittal deleted the fix-component-external-reference-column-mapping branch October 3, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants