Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /api/v1/event/token/{uuid} not checking workflow states #915

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Sep 19, 2024

Description

Fixes /api/v1/event/{token} not checking workflow states.

/api/v1/bom/{token} was deprecated in v4.11 and removed in #910.

Since BOM upload progress is tracked in durable workflows in v5, the new event endpoint must be adapted to check those as well.

Addressed Issue

N/A

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have updated the migration changelog accordingly
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

`/api/v1/bom/{token}` was deprecated in v4.11 and removed in #910.

Since BOM upload progress is tracked in durable workflows in v5, the new `event` endpoint must be adapted to check those as well.

Signed-off-by: nscuro <[email protected]>
@nscuro nscuro added the defect Something isn't working label Sep 19, 2024
@nscuro nscuro added this to the 5.6.0 milestone Sep 19, 2024
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.04% (target: -1.00%) 85.71% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8c5ab17) 21345 17563 82.28%
Head commit (cb1b422) 21349 (+4) 17575 (+12) 82.32% (+0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#915) 7 6 85.71%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro changed the title Fix /api/v1/event/{token} not checking workflow states Fix /api/v1/event/token/{uuid} not checking workflow states Sep 19, 2024
@sahibamittal sahibamittal merged commit 37351e4 into main Sep 19, 2024
9 checks passed
@sahibamittal sahibamittal deleted the fix-event-status-endpoint branch September 19, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants