Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock singleton tasks #222

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Lock singleton tasks #222

merged 3 commits into from
Jul 7, 2023

Conversation

VithikaS
Copy link
Collaborator

@VithikaS VithikaS commented Jul 6, 2023 •
edited
Loading

Description

This PR locks all singleton tasks so we have only one pod executing tasks

Screenshot 2023-07-05 at 19 37 42

Addressed Issue

It addresses some of the issues in DependencyTrack/hyades#375

Additional Details

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

lock signgleton tasks
dacc2b3 
Signed-off-by: vithikashukla <[email protected]>
nscuro
nscuro reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor suggestions! 🤏

src/main/java/org/dependencytrack/tasks/EpssMirrorTask.java Outdated Show resolved Hide resolved
src/main/java/org/dependencytrack/event/LdapSyncEvent.java Outdated Show resolved Hide resolved
src/main/java/org/dependencytrack/tasks/InternalComponentIdentificationTask.java Outdated Show resolved Hide resolved
vithikashukla added 2 commits July 6, 2023 16:17
address review comments
c327041 
Signed-off-by: vithikashukla <[email protected]>
address review comments
952c8bc 
Signed-off-by: vithikashukla <[email protected]>
@nscuro nscuro added the enhancement New feature or request label Jul 7, 2023
@VithikaS VithikaS merged commit 649756c into main Jul 7, 2023
5 checks passed
@VithikaS VithikaS deleted the lock-singleton-tasks branch July 7, 2023 13:01
@nscuro nscuro mentioned this pull request Jul 28, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nscuro nscuro nscuro approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VithikaS @nscuro