Additional LongPollWait supporting code #11

johnmaguire · 2024-05-30T21:07:42Z

Support for non-streaming CommandResponse
Updated timeouts to support headers not being sent immediately
Fix StreamController.Write behavior (error dampening can occur in dnclient)
Defer Action unmarshalling and include ResponseToken in LongPollWait responses
Include Response in CommandResponseRequest
Wrap HTTP Do calls to allow callers to detect context.Canceled in the middle of a long poll request

client.go

johnmaguire added 2 commits May 30, 2024 16:56

Additional LongPollWait code

5e52425

Even more supporting code

fd884a7

brad-defined reviewed Jun 6, 2024

View reviewed changes

client.go Show resolved Hide resolved

client.go Outdated Show resolved Hide resolved

Fix CommandResponse and add test

1be739b

johnmaguire changed the title ~~Additional LongPollWait code~~ Additional LongPollWait supporting code Jun 6, 2024

johnmaguire requested a review from brad-defined June 6, 2024 16:53

brad-defined reviewed Jun 6, 2024

View reviewed changes

client.go Outdated Show resolved Hide resolved

brad-defined previously approved these changes Jun 6, 2024

View reviewed changes

bump timeout to 2 mins

5ec19b1

johnmaguire dismissed brad-defined’s stale review via 5ec19b1 June 6, 2024 17:38

johnmaguire requested a review from brad-defined June 6, 2024 17:38

brad-defined previously approved these changes Jun 6, 2024

View reviewed changes

test

a077c5f

johnmaguire dismissed brad-defined’s stale review via a077c5f June 6, 2024 17:41

johnmaguire requested a review from brad-defined June 6, 2024 17:41

brad-defined approved these changes Jun 6, 2024

View reviewed changes

johnmaguire merged commit 1568017 into main Jun 6, 2024
2 checks passed

johnmaguire deleted the longpollwait branch June 6, 2024 18:13

Provide feedback