update sprocket gem to handle vulnerability issues #421
Conversation
DanielAmah
force-pushed
the
update-sprocket-rails-gem
branch
3 times, most recently
from
600d1ab
to
ed3b2ea
Compare
| @@ -58,5 +58,6 @@ class Application < Rails::Application | |||
| # config.i18n.default_locale = :de | |||
| config.secret_token = ENV["SECRET_TOKEN"] | |||
| config.active_record.raise_in_transactional_callbacks = true | |||
| config.assets.precompile << %w(landing.css) | |||
There was a problem hiding this comment.
Style/PercentLiteralDelimiters: %w-literals should be delimited by [ and ].
There was a problem hiding this comment.
I don't think you need to make this explicit, they are automagically precompiled on deploy.
There was a problem hiding this comment.
I did this because of the upgrade of the sprocket version demands that I specify this explicitly. It was throwing an error that landing.css was missing ....
Gemfile
Outdated
| @@ -40,7 +40,7 @@ gem "paperclip", "~> 5.1.0" | |||
| gem "aws-sdk" | |||
| gem "redcarpet" | |||
| gem "holidays" | |||
| gem "sprockets-rails", "~> 2.3" | |||
| gem 'sprockets-rails', "~>3.0" | |||
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
DanielAmah
force-pushed
the
update-sprocket-rails-gem
branch
2 times, most recently
from
783d2a8
to
2a8de71
Compare
config/application.rb
Outdated
| @@ -58,5 +58,6 @@ class Application < Rails::Application | |||
| # config.i18n.default_locale = :de | |||
| config.secret_token = ENV["SECRET_TOKEN"] | |||
| config.active_record.raise_in_transactional_callbacks = true | |||
| config.assets.precompile %w(landing.css) | |||
There was a problem hiding this comment.
Layout/ExtraSpacing: Unnecessary spacing detected.
Layout/SpaceBeforeFirstArg: Put one space between the method name and the first argument.
Style/PercentLiteralDelimiters: %w-literals should be delimited by [ and ].
DanielAmah
force-pushed
the
update-sprocket-rails-gem
branch
from
2a8de71
to
0fbdd2d
Compare
| @@ -58,5 +58,6 @@ class Application < Rails::Application | |||
| # config.i18n.default_locale = :de | |||
| config.secret_token = ENV["SECRET_TOKEN"] | |||
| config.active_record.raise_in_transactional_callbacks = true | |||
| config.assets.precompile << %w(landing.css) | |||
There was a problem hiding this comment.
I don't think you need to make this explicit, they are automagically precompiled on deploy.
PR description
Issue
#420