trace: tag http.route on api-gateway spans #530
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-id
reviewed
Apr 9, 2024
| @@ -141,7 +141,7 @@ export function parseEventSource(event: any) { | |||
| return eventTypes.lambdaUrl; | |||
| } | |||
| if ( | |||
| eventType.isAPIGatewayEvent(event) || | |||
| eventType.(event) || | |||
There was a problem hiding this comment.
Is this a bad copy paste ? it's a syntax error and i'm not sure what you tried to do ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the missing http.route tag to api gateway spans.
Motivation
Support the APM's API Catalog which uses this span tag to list the entries of the API Catalog.
Testing Guidelines
TODO - this is just a draft PR to bootstrap the work and help relevant teams
Additional Notes
Types of Changes
Check all that apply