Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Clean build and copy handler.js #307

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Conversation

astuyve
Copy link
Contributor

@astuyve astuyve commented Sep 2, 2022

What does this PR do?

Removes a local dist directory if it exists, and then copies the cjs handler to be just a regular handler.js, which was removed in 6.76 (but phantom-published until 6.82, as yarn doesn't perform clean builds)

closes #305

Motivation

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@astuyve astuyve requested a review from a team as a code owner September 2, 2022 17:40
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2022

Codecov Report

Merging #307 (44f50f3) into main (5d7862c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files          36       36           
  Lines        1715     1715           
  Branches      387      387           
=======================================
  Hits         1373     1373           
  Misses        290      290           
  Partials       52       52           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@astuyve astuyve merged commit a484143 into main Sep 9, 2022
@astuyve astuyve deleted the aj/re-copy-handler-js branch September 9, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 6.82.0 breaks AWS RIC support
3 participants