feat: Add option for Processor to drop metrics #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add two parameters
MetricsChannelCapacity
andDropMetricsAtCapacity
.This will allow the
AddMetric
function to be truly non-blocking even if we risk loosing some metrics.The default will remain at a channel capacity of 2000 and blocking to wait for capacity.
Another try after #130 got closed due to stale activity.
Motivation
Following the DataDog outage of 2023.03.08 in EU central some of our Lambdas were blocking due to the blocking nature of the
AddMetric
function in cases where themetricsChan
is at capacity.Testing Guidelines
Added test case
TestProcessorBatchesDropMetricsAtCapacity
Additional Notes
Types of changes
Checklist