[.NET Profiler] Setup env var(s) for profiler #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewlock
approved these changes
Sep 26, 2023
| export LD_PRELOAD="${DD_DIR}/continuousprofiler/Datadog.Linux.ApiWrapper.x64.so" | ||
| fi | ||
| echo "Creating log folder for .NET APM" | ||
| ${DD_DIR}/createLogPath.sh |
There was a problem hiding this comment.
I'm kind of surprised we weren't doing this already 😅 we may need to make this executable first?
Alternatively, I think you can run it as (but don't quote me):
Suggested change
| ${DD_DIR}/createLogPath.sh | |
| sh ${DD_DIR}/createLogPath.sh |
|
|
||
| if [[ "${DD_PROFILING_ENABLED:-,,}" == "1" ]]; then | ||
| echo "Profiler is enabled." | ||
| export LD_PRELOAD="${DD_DIR}/continuousprofiler/Datadog.Linux.ApiWrapper.x64.so" |
There was a problem hiding this comment.
I'm wondering if we definitely want to overwrite LD_PRELOAD or "append" to it? (I don't know if that's a thing for LD_PRELOAD)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable the profiler, we need to set the
LD_PRELOADenv var. We will set the env var for the customers to avoid painful configuration on their end.Create log folders so we can retrieve them in case of customer case