Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid warning (and dismissal) of objects in input array when using mb_convert_encoding #223

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

remyroussel
Copy link
Contributor

@remyroussel remyroussel commented Oct 7, 2024

Since commit e5ab4e3, we allow TransactionProcessor::audit $data['diff'] arrays to be handled by mb_convert_encoding (only string was before).
Problem is when an object is inside array (first level or deeper nested), mb_convert_encoding triggers a warning (and object is filtered out of result).

Linked to issue #220

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.43%. Comparing base (94e297d) to head (8900218).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #223      +/-   ##
==========================================
- Coverage   97.15%   96.43%   -0.72%     
==========================================
  Files          42       42              
  Lines        1721     1712       -9     
==========================================
- Hits         1672     1651      -21     
- Misses         49       61      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DamienHarper DamienHarper merged commit f40db64 into DamienHarper:master Oct 8, 2024
20 checks passed
@DamienHarper
Copy link
Owner

Thanks @remyroussel 👍🏽

@DamienHarper
Copy link
Owner

fixed in 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants