Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getWrappedConnection is deprecated #222

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

dmitryuk
Copy link
Contributor

@dmitryuk dmitryuk commented Oct 1, 2024

MR to fix getWrappedConnection is deprecated
Also not to calculate version if not mysql or mariadb

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.42%. Comparing base (94e297d) to head (92a8f80).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
...der/Doctrine/Persistence/Helper/PlatformHelper.php 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
- Coverage   97.15%   96.42%   -0.74%     
==========================================
  Files          42       42              
  Lines        1721     1705      -16     
==========================================
- Hits         1672     1644      -28     
- Misses         49       61      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DamienHarper DamienHarper merged commit eefe736 into DamienHarper:master Oct 8, 2024
22 checks passed
@DamienHarper
Copy link
Owner

Thanks @dmitryuk

@DamienHarper
Copy link
Owner

fixed in 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants