Small fixes to PlatformHelper.php #218
Conversation
Conditional checks for existence of 'getNativeConnection' method, but then it doesn't call that method at all, and attempts to call directly `$connection->getServerVersion()`, which would fail because that method is private.
…may not have a patch version, in which case $versionParts will be `[]`.
yivi
changed the title
| @@ -104,11 +104,11 @@ public static function getOracleMysqlVersionNumber(string $versionString): strin | |||
| public static function getMariaDbMysqlVersionNumber(string $versionString): string | |||
| { | |||
| preg_match( | |||
| '#^(?:5\.5\.5-)?(mariadb-)?(?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)#i', | |||
| '#^(?:5\.5\.5-)?(mariadb-)?(?P<major>\d+)\.(?P<minor>\d+)(\.(?P<patch>\d+))?#i', | |||
There was a problem hiding this comment.
Well, I assume you're right even if this regex comes from doctrine/dbal itself: https://github.com/doctrine/dbal/blob/7a8252418689feb860ea8dfeab66d64a56a64df8/src/Driver/AbstractMySQLDriver.php#L96
There was a problem hiding this comment.
I just got the error when I was running tests.
$versionString, as reported by a local postrgres running in a container, was "13.16"
That string matches what I'd expect when checking postgres releases:
https://www.postgresql.org/docs/release/
Maybe the problem is that this function was called to parse a postgres version, and it should be reserved for a MariaDb version.
There was a problem hiding this comment.
When I changed the regex I was able to run my project's tests again.
There was a problem hiding this comment.
Yeah, on further inspection, I think the problem is that this version-parsing is being called when not needed. I believe the problem may come from isJsonSupported().
There was a problem hiding this comment.
You're right, isJsonSupported() seems to be the culprit, will post a fix soon.
Would you mind dumping $version after
There was a problem hiding this comment.
Thanks, I hadn't understood you got the version that way ;)
There was a problem hiding this comment.
#219 should fix your issues
There was a problem hiding this comment.
…nString may not have a patch version, in which case $versionParts will be `[]`." This reverts commit 3e27a78.
$connection->getServerVersion(), which would fail because that method is private.fix getMariaDbMysqlVersionNumber(), because sometimes $versionString may not have a patch version, in which case $versionParts will be[].