Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doctrine/orm to 3.0.0 #193

Closed
wants to merge 1 commit into from

Conversation

JeroenMoonen
Copy link

@JeroenMoonen JeroenMoonen commented Feb 15, 2024

After updating, DamienHarper/auditor-bundle can be updated as well.

Copy link

@maxhelias maxhelias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are no changes, why remove compatibility with ^2.13?
BTW, I haven't looked at how the package works, but no change to be compatible with ORM 3 seems suspicious to me.

Copy link
Owner

@DamienHarper DamienHarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeroenMoonen Supporting ORM 3.x is way more complex than updating the composer.json file. Many BC breaks were introduced in ORM 3.x (see https://github.com/doctrine/orm/blob/3.1.x/UPGRADE.md#upgrade-to-30)
Then, supporting both ORM 2.x and 3.x is another piece of work.

@DamienHarper
Copy link
Owner

Closed in favor of #207

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants