Skip to content

Commit

Permalink
List support only works with Connection::execute() (#21)
Browse files Browse the repository at this point in the history
  • Loading branch information
Maksim authored Feb 6, 2021
1 parent fe26ddc commit feae12d
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/Provider/Doctrine/Persistence/Reader/Query.php
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ private function buildWhere(QueryBuilder $queryBuilder): QueryBuilder
} else {
$queryBuilder
->andWhere(sprintf('%s IN (:%s)', $filter, $filter))
->setParameter($filter, $values)
->setParameter($filter, $values, Connection::PARAM_STR_ARRAY)
;
}
}
Expand Down
15 changes: 15 additions & 0 deletions tests/Provider/Doctrine/Persistence/Reader/ReaderTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,21 @@ public function testGetAuditsPager(): void
self::assertSame(3, $pager['numPages'], 'Pager has 3 pages.');
}

public function testMultipleFilters(): void
{
$reader = $this->createReader();

$query = $reader->createQuery(Author::class);
$audits = $query->execute();
self::assertCount(5, $audits);

$query = $reader->createQuery(Author::class);
$query->addFilter('object_id', 1);
$query->addFilter('object_id', 2);
$audits = $query->execute();
self::assertCount(3, $audits);
}

/**
* @depends testGetAudits
*/
Expand Down

0 comments on commit feae12d

Please sign in to comment.