Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test deps, fixes CI for 6.x #399

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Update test deps, fixes CI for 6.x #399

merged 3 commits into from
Jan 21, 2024

Conversation

DamienHarper
Copy link
Owner

No description provided.

@DamienHarper DamienHarper force-pushed the update-tests branch 2 times, most recently from 5f48046 to 52c2af8 Compare January 3, 2024 21:34
@DamienHarper DamienHarper force-pushed the update-tests branch 3 times, most recently from 00a9b1e to c628a9c Compare January 21, 2024 15:45
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3d9b741) 93.14% compared to head (d4a74ee) 92.47%.
Report is 1 commits behind head on master.

Files Patch % Lines
src/Routing/RoutingLoader.php 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
- Coverage   93.14%   92.47%   -0.67%     
==========================================
  Files          15       15              
  Lines         350      359       +9     
==========================================
+ Hits          326      332       +6     
- Misses         24       27       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DamienHarper DamienHarper merged commit ad99d01 into master Jan 21, 2024
10 checks passed
@DamienHarper DamienHarper deleted the update-tests branch January 21, 2024 16:58
@gassan
Copy link

gassan commented Jan 21, 2024

Not sure but I think symfony 5.4 has no @routing.loader.attribute service. So symfony/* ^5.4 must be removed.

@gassan
Copy link

gassan commented Jan 21, 2024

Symfony 5.4 + auditor-bundle 6.x
The service "DH\AuditorBundle\Routing\RoutingLoader" has a dependency on a
!! non-existent service "routing.loader.attribute". Did you mean one of these:
!! "routing.loader.glob", "routing.loader.container"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants