Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ViewerController final #385

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

OskarStark
Copy link
Contributor

Follows #379 (comment)

Afterwards we can make it final final in master 👍

cc @mvhirsch

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f01a6e0) 93.14% compared to head (4919fe6) 93.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##              5.x     #385   +/-   ##
=======================================
  Coverage   93.14%   93.14%           
=======================================
  Files          15       15           
  Lines         350      350           
=======================================
  Hits          326      326           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DamienHarper DamienHarper merged commit 95a832a into DamienHarper:5.x Dec 22, 2023
12 checks passed
@OskarStark OskarStark deleted the final branch December 23, 2023 11:15
DamienHarper added a commit that referenced this pull request Jul 14, 2024
* Updated CI

* Fixed middlewares override (#341)

* Revert unwanted PHP >= 8.0 changes

* Updated branch alias

* Reverted and adjusted middleware test

* Adjusted middleware registration priority (fixed failing tests)

* Fixed unwanted deps changes

* Fixed failing test

* #345 Deprecation in RoleChecker and UserProvider (#350)

* #345 Deprecation in RoleChecker and UserProvider

* remove line

---------

Co-authored-by: a.dmitryuk <[email protected]>

* Fixed CI (PHPStan)

* Support doctrine/annotations:2.0 (#351)

* remove doctrine/annotations from composer.json

* doctrine/annotations 2.0

---------

Co-authored-by: a.dmitryuk <[email protected]>

* Fixed compatibility with Symfony 4.4

* PHP-CS-Fixer

* Fixed CI (#367)

* PHP-CS-Fixer

* Fix: `ViewerController` (#379)

* Fix: `ViewerController`

* -

* -

* -

* Fixed remaining calls to AbstractController methods.

* -

* -

* -

* -

* PHP-CS-Fixer

---------

Co-authored-by: Damien Harper <[email protected]>

* CI updates

* Make `ViewerController` final (#385)

Co-authored-by: Damien Harper <[email protected]>

* Test more PHP versions (#389)

Co-authored-by: Damien Harper <[email protected]>

* Use `actions/checkout@v4` (#387)

Co-authored-by: Damien Harper <[email protected]>

* PHP-CS-Fixer

* Update deps + PHP-CS-Fixer

* PHP-CS-Fixer (3.48.0)

* 6.x

Signed-off-by: Oleg Andreyev <[email protected]>

* reverted ci-5.x.yml

Signed-off-by: Oleg Andreyev <[email protected]>

* reverted ci-5.x.yml

Signed-off-by: Oleg Andreyev <[email protected]>

* clean composer.json

Signed-off-by: Oleg Andreyev <[email protected]>

* reverted ci-4.x.yml

Signed-off-by: Oleg Andreyev <[email protected]>

* damienharper/auditor dev-master

Signed-off-by: Oleg Andreyev <[email protected]>

* allow ^3.1 orm

Signed-off-by: Oleg Andreyev <[email protected]>

---------

Signed-off-by: Oleg Andreyev <[email protected]>
Co-authored-by: Damien Harper <[email protected]>
Co-authored-by: Alexander Dmitryuk <[email protected]>
Co-authored-by: a.dmitryuk <[email protected]>
Co-authored-by: Oskar Stark <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants