Boolean values are properly displayed now (fix #166) (#167)

DamienHarper · Feb 6, 2020 · 9b28c3e · 9b28c3e
1 parent 045295f
commit 9b28c3e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/DoctrineAuditBundle/Resources/views/Audit/entry.html.twig b/src/DoctrineAuditBundle/Resources/views/Audit/entry.html.twig
@@ -37,7 +37,7 @@
                             <td><code>{{ key }}</code></td>
                             <td>
                                 {% if values.old is defined %}
-                                    {% if values.old is empty %}
+                                    {% if values.old is null %}
                                         {{ bootstrap.badge('null', 'secondary') }}
                                     {% else %}
                                         {{ bootstrap.text(helper.dump(values.old), 'danger') }}
@@ -46,10 +46,10 @@
                             </td>
                             <td>
                                 {% if values.new is defined %}
-                                    {% if values.new is empty %}
+                                    {% if values.new is null %}
                                         {{ bootstrap.badge('null', 'secondary') }}
                                     {% else %}
-                                        {% if values.old is empty %}
+                                        {% if values.old is null %}
                                             {{ bootstrap.text(helper.dump(values.new), 'primary') }}
                                         {% else %}
                                             {{ bootstrap.text(helper.dump(values.new), 'success') }}

diff --git a/src/DoctrineAuditBundle/Resources/views/Audit/helpers/helper.html.twig b/src/DoctrineAuditBundle/Resources/views/Audit/helpers/helper.html.twig
@@ -1,12 +1,17 @@
 {% macro dump(value, separator) %}
 {% import _self as helper %}
+{% import '@DHDoctrineAudit/Audit/bootstrap.html.twig' as bootstrap %}
 {% apply spaceless %}
     {% if value.label is defined %}
         {{ value.label }}
     {% elseif value is iterable %}
         {% for k, v in value %}
             {{ k }}: {{ helper.dump(v) }}{{ separator|default('<br/>')|raw }}
         {% endfor %}
+    {% elseif value is same as(true) %}
+        {{ 'true' }}
+    {% elseif value is same as(false) %}
+        {{ 'false' }}
     {% else %}
         {{ value }}
     {% endif %}