Fix deprecation notice regarding twig usage from controller. Should h…

…elp for Symfony 6 compat. (#273)
DamienHarper · Sep 26, 2021 · 564d8f7 · 564d8f7
1 parent 2806bf8
commit 564d8f7
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 0 deletions.
diff --git a/src/Controller/ViewerController.php b/src/Controller/ViewerController.php
@@ -15,6 +15,13 @@
 
 class ViewerController extends AbstractController
 {
+    private $environment;
+
+    public function __construct(\Twig\Environment $environment)
+    {
+        $this->environment = $environment;
+    }
+
     /**
      * @Route("/audit", name="dh_auditor_list_audits", methods={"GET"})
      */
@@ -90,4 +97,9 @@ public function showEntityHistoryAction(Request $request, Reader $reader, string
             'paginator' => $pager,
         ]);
     }
+
+    protected function renderView(string $view, array $parameters = []): string
+    {
+        return $this->environment->render($view, $parameters);
+    }
 }
diff --git a/src/Resources/config/services.yaml b/src/Resources/config/services.yaml
@@ -60,6 +60,7 @@ services:
 
   # Bundle related services
   DH\AuditorBundle\Controller\ViewerController:
+    arguments: ['@twig']
     calls:
       - { method: setContainer, arguments: ['@service_container'] }
     tags: ['controller.service_arguments']

diff --git a/tests/DHAuditorBundleTest.php b/tests/DHAuditorBundleTest.php
@@ -15,6 +15,7 @@
 use Nyholm\BundleTest\BaseBundleTestCase;
 use Nyholm\BundleTest\CompilerPass\PublicServicePass;
 use Symfony\Bundle\SecurityBundle\SecurityBundle;
+use Symfony\Bundle\TwigBundle\TwigBundle;
 use Symfony\Component\HttpKernel\Kernel;
 
 /**
@@ -44,6 +45,7 @@ public function testInitBundle(): void
 
         $kernel->addBundle(DoctrineBundle::class);
         $kernel->addBundle(SecurityBundle::class);
+        $kernel->addBundle(TwigBundle::class);
 
         $this->bootKernel();
 

diff --git a/tests/Twig/Extension/TwigExtensionTest.php b/tests/Twig/Extension/TwigExtensionTest.php
@@ -8,6 +8,7 @@
 use Nyholm\BundleTest\BaseBundleTestCase;
 use Nyholm\BundleTest\CompilerPass\PublicServicePass;
 use Symfony\Bundle\SecurityBundle\SecurityBundle;
+use Symfony\Bundle\TwigBundle\TwigBundle;
 use Symfony\Component\HttpKernel\Kernel;
 
 /**
@@ -36,6 +37,7 @@ protected function setUp(): void
 
         $kernel->addBundle(DoctrineBundle::class);
         $kernel->addBundle(SecurityBundle::class);
+        $kernel->addBundle(TwigBundle::class);
 
         $this->bootKernel();