Ignore unknown node types #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
============================================
+ Coverage 91.52% 91.54% +0.01%
- Complexity 276 277 +1
============================================
Files 76 76
Lines 861 863 +2
============================================
+ Hits 788 790 +2
Misses 73 73 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We came across a Jira issue description that included a type called mediaInline. It caused the parser to crash:
Undefined array key "mediaInline"
vendor/damienharper/adf-tools/src/Node/BlockNode.php:40 DH\Adf\Node\BlockNode::load
This PR includes a condition that ignores undefined types and allows the loading process to continue.