Fix Deep and RoleTag accessor behavior #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By inheriting from DirectProxyAccessor, DeepProxyAccessor also unintentionally inherited the behaviors that allowed creating objects. This recently led to confusion as to what's possible and what isn't. Part of the fix to #446.
Previously when retrieving objects using a RoleTagAccessor that has a non-empty `classes` argument, objects that didn't match the specified classes were simply filtered out and ignored. This caused two problems: 1. It made it more difficult to spot potential metamodel mismatches with upstream Capella. 2. The implementation (using `ElementList.filter`) decoupled the list from the model and therefore prevented modifying the model through it. This commit changes the implementation to strictly verify that the actual classes match those expected by the metamodel, and will raise an exception in case of any mismatch. Part of the fix to #446.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the bugs in DeepProxyAccessor and RoleTagAccessor, discussed in #446.