Fix (some) deprecation warnings #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the PEP-702 `@deprecated` decorator to mark deprecated methods and classes where possible. This makes deprecation information available to static type checkers like mypy. This commit also adds the deprecation plugin from `mypypp` in order to add early support for the feature to mypy.
This solves all static deprecation warnings discovered by the previous commit, and wmultiple runtime-only warnings that have been around for a while now.
Keeping instances of GenericElement and its subclasses hashable has caused problems in the past, especially in the case of custom equality operators. Those problems include ambiguity about what gets hashed, as well as hashing over mutable attributes, which both can cause the object in question to end up in an unexpected hash bucket in one way or another, which in turn leads to extremely difficult to diagnose issues downstream. This is why hashing is now deprecated for all elements. Previously it was only deprecated for a limited number of object types, where it was definitely known to cause problems; this change improves consistency across the API and prevents unexpected TypeErrors if unhashable objects suddenly end up in hashing contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.