Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ADD: Functionality to generate an AuthorizationURL for a selfdefined… #131

Merged
merged 6 commits into from
Jul 18, 2023
Merged

+ADD: Functionality to generate an AuthorizationURL for a selfdefined… #131

merged 6 commits into from
Jul 18, 2023

Conversation

Frank-Wiebeler
Copy link
Member

… state rather than one that's provided by the library

@saschadoemer
Copy link
Member

@Frank-Wiebeler The test is failing. I added an implementation to make the test work and clean the code a little.

image

@saschadoemer
Copy link
Member

@Frank-Wiebeler Could you take a look at it?

saschadoemer
saschadoemer approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@saschadoemer saschadoemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed some smaller code fragments and made the tests work.

Frank-Wiebeler
Frank-Wiebeler commented Jul 18, 2023
View reviewed changes
Copy link
Member Author

@Frank-Wiebeler Frank-Wiebeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your adjustments

@saschadoemer saschadoemer merged commit ea2d619 into main Jul 18, 2023
1 check passed
@saschadoemer saschadoemer deleted the feature/auth-url-from-state branch July 19, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschadoemer saschadoemer saschadoemer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Frank-Wiebeler @saschadoemer