Windows OPENSSL_Applink error patch #29
Conversation
|
I think this may also need to be wrapped with version(Window), and at least be tested that there are no problems on a non-Windows system. |
|
LGTM, but I think a dub user should look at this first to make sure the module isn't being linked in unless necessary or explicitly requested by the user. |
| return _fileno(fp); | ||
| } | ||
|
|
||
| int app_fsetmod(FILE *fp, char mod) |
There was a problem hiding this comment.
You don't want to export the implementations, only OPENSSL_Applink.
|
Please make sure to ping (short comment) when pushing new commits, as github doesn't notify about this. |
| @@ -0,0 +1,115 @@ | |||
| module deimos.openssl.applink; | |||
There was a problem hiding this comment.
We want a version (Windows) here.
The following should work, please test it. "configurations" : [
{
"name": "library",
"excludedSourceFiles": ["deimos/openssl/applink.d"],
"targetType": "sourceLibrary",
},
{
"name": "library-applink",
"targetType": "sourceLibrary",
},
]To use applink in you project, you'd have to select a subconfiguration like so. "subConfigurations": {
"openssl": "library-applink"
}, |
|
After fixing things, add "This fixes #28" to the description so they close together. |
|
Did this never get merged? or is this no longer an issue? |
Solves the OPENSSL_Applink error when using Windows DLLs. Provides a D translation for the applink.c which is normally used to avoid this error in C. The original applink.c source code from OpenSSL has been included for reference.