Duplicate properties #1403
Merged
Duplicate properties #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roland Asmann <[email protected]>
Signed-off-by: Roland Asmann <[email protected]>
|
Will fix the repotests in a separate PR. |
|
@prabhu just a little heads-up on the repotests: it looks like it's custom-json-diff that's having the issue, not cdxgen. Not sure if cjd has been updated lately, but on my local tests, everything was fine. |
|
Correct. v2 is out with a new command. Could you kindly update based on the latest snapshot tests and share a PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes both the duplicate properties (#1401) and, for Gradle, the usage of a project name as a profile.
The issue for the duplicate properties was not in Gradle-specific code, so this could influence/fix issues with duplicate properties for other languages/tools as well!