Skip to content

Commit

Permalink
[iOS] <select multiple> group headers are illegible in dark mode
Browse files Browse the repository at this point in the history
https://bugs.webkit.org/show_bug.cgi?id=222914
<rdar://problem/75020326>

Reviewed by Tim Horton.

* UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKSelectPickerTableViewController tableView:heightForHeaderInSection:]):

Do not specify a textColor for the header label. This ensures the default
semantic label color is used, which automatically adapts when dark mode
is enabled.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@274085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
[email protected] committed Mar 8, 2021
1 parent 4dc02b7 commit b6e0c53
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
15 changes: 15 additions & 0 deletions Source/WebKit/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
2021-03-08 Aditya Keerthi <[email protected]>

[iOS] <select multiple> group headers are illegible in dark mode
https://bugs.webkit.org/show_bug.cgi?id=222914
<rdar://problem/75020326>

Reviewed by Tim Horton.

* UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKSelectPickerTableViewController tableView:heightForHeaderInSection:]):

Do not specify a textColor for the header label. This ensures the default
semantic label color is used, which automatically adapts when dark mode
is enabled.

2021-03-08 Chris Dumez <[email protected]>

Simplify CallbackAggregator in WebsiteDataStore::removeData()
Expand Down
1 change: 0 additions & 1 deletion Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,6 @@ - (UIView *)tableView:(UITableView *)tableView viewForHeaderInSection:(NSInteger

auto sectionLabel = adoptNS([[UILabel alloc] init]);
[sectionLabel setText:[self tableView:tableView titleForHeaderInSection:section]];
[sectionLabel setTextColor:UIColor.blackColor];
[sectionLabel setFont:[UIFont boldSystemFontOfSize:sectionHeaderFontSize]];
[sectionLabel setAdjustsFontSizeToFitWidth:NO];
[sectionLabel setLineBreakMode:NSLineBreakByTruncatingTail];
Expand Down

0 comments on commit b6e0c53

Please sign in to comment.