Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gamelog render to yaml in issue template #2654

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lewri
Copy link
Member

@lewri lewri commented Oct 3, 2024

For issue templates we put the gamelog text in bash. However, the way we render gamelog data is more legible in yaml.

Bash:

Warning: Trying to remove nonexistent staff callback (function: 0000015E54720E90) from humanoid (table: 0000015E52626FE0).
Warning: Trying to resolve door deadlock at (29, 50)
Error in timer handler: 
Lua\entities\humanoid.lua:472: assertion failed!
stack traceback:
	[C]: in function 'assert'
	Lua\entities\humanoid.lua:472: in method 'startAction'
	Lua\entities\humanoid.lua:577: in method 'finishAction'
	Lua\humanoid_actions\use_screen.lua:48: in local 'timer_function'
	Lua\entity.lua:216: in method 'tick'
	Lua\world.lua:1074: in method 'onTick'
	Lua\app.lua:1202: in function <Lua\app.lua:1199>
	(...tail calls...)
	Lua\app.lua:1102: in function <Lua\app.lua:1097>

yaml

Warning: Trying to remove nonexistent staff callback (function: 0000015E54720E90) from humanoid (table: 0000015E52626FE0).
Warning: Trying to resolve door deadlock at (29, 50)
Error in timer handler: 
Lua\entities\humanoid.lua:472: assertion failed!
stack traceback:
        [C]: in function 'assert'
        Lua\entities\humanoid.lua:472: in method 'startAction'
        Lua\entities\humanoid.lua:577: in method 'finishAction'
        Lua\humanoid_actions\use_screen.lua:48: in local 'timer_function'
        Lua\entity.lua:216: in method 'tick'
        Lua\world.lua:1074: in method 'onTick'
        Lua\app.lua:1202: in function <Lua\app.lua:1199>
        (...tail calls...)
        Lua\app.lua:1102: in function <Lua\app.lua:1097>

@TheCycoONE
Copy link
Member

Odd... it isn't yaml. Should it have a renderer. Should it be yaml?

@TheCycoONE
Copy link
Member

Maybe include some samples in the description

@lewri
Copy link
Member Author

lewri commented Oct 4, 2024

Odd... it isn't yaml. Should it have a renderer. Should it be yaml?

Samples added. Gamelog paste needs a renderer or the text block goes weird.
Yaml appears to take our liking to a:b format of gamelog, probably accidental.

However, I'm not sure if our gamelog is using an 8 space tab rather than actual spaces; which yaml actually doesn't seem to like. Yaml renders that as

	

So that could be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants