-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Overhaul training #2314
Open
lewri
wants to merge
5
commits into
CorsixTH:master
Choose a base branch
from
lewri:training_overhaul
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[RFC] Overhaul training #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewri
commented
Mar 14, 2023
lewri
force-pushed
the
training_overhaul
branch
from
March 14, 2023 19:16
44b4875
to
2a416c6
Compare
lewri
commented
Mar 14, 2023
lewri
commented
Mar 14, 2023
lewri
commented
Mar 31, 2023
lewri
changed the title
[WIP] Testing Required - Overhaul training
[RFC] Testing Required - Overhaul training
Apr 20, 2023
lewri
changed the title
[RFC] Testing Required - Overhaul training
Testing Required - Overhaul training
May 10, 2023
As Alberth said, we're not likely to get balance testers until the PR is in the game so I've marked as ready. If we're merging let me know first so I can remove all the comments for the wiki. |
Wiki comments removed now ahead of time. You can view them still under 98bb983 as removed lines. |
lewri
commented
Aug 13, 2023
lewri
force-pushed
the
training_overhaul
branch
from
September 10, 2023 15:57
d652ef7
to
47343c4
Compare
lewri
force-pushed
the
training_overhaul
branch
from
December 23, 2023 19:11
47343c4
to
9784027
Compare
lewri
force-pushed
the
training_overhaul
branch
from
January 29, 2024 19:27
1bc9a02
to
7a38fad
Compare
lewri
force-pushed
the
training_overhaul
branch
from
February 18, 2024 17:56
7a38fad
to
68db169
Compare
So it actually benefits adding more objects to the room (with diminishing benefits)
lewri
force-pushed
the
training_overhaul
branch
from
February 19, 2024 20:39
68db169
to
3067c17
Compare
Great enhancement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1458
Fixes #2262
Fixes #2603
Describe what the proposed change does
math.rand modulo
function was not incorporated, as it caused a lot of groundhog day scenarios with docs nearer consultant levelFor award values following this PR: (before PR general skill was 0.0035 regardless of factors)
(Another comparison is Cons. Psychiatrist with trainee psych skill per day: Before PR - 0.0118; After PR: - 0.0105)
Please do test this as I need to know whether the balance is correct. If you need a good level in the main game try Level 9