Implemented decoding and hash rules for execution requests #8668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfukushima
approved these changes
Oct 2, 2024
.../pegasys/teku/spec/datastructures/execution/versions/electra/ExecutionRequestsDataCodec.java
Outdated
Show resolved
Hide resolved
rolfyone
reviewed
Oct 2, 2024
Comment on lines
23
to
25
| /* | ||
| https://eips.ethereum.org/EIPS/eip-7251 | ||
| */ |
There was a problem hiding this comment.
if we do need this comment at all, maybe single line?
rolfyone
reviewed
Oct 2, 2024
Comment on lines
44
to
68
| switch (type) { | ||
| case DepositRequest.REQUEST_TYPE: | ||
| // https://eips.ethereum.org/EIPS/eip-6110 | ||
| executionRequestsBuilder.deposits( | ||
| executionRequestsSchema | ||
| .getDepositRequestsSchema() | ||
| .sszDeserialize(data.slice(1)) | ||
| .asList()); | ||
| break; | ||
| case WithdrawalRequest.REQUEST_TYPE: | ||
| // https://eips.ethereum.org/EIPS/eip-7002 | ||
| executionRequestsBuilder.withdrawals( | ||
| executionRequestsSchema | ||
| .getWithdrawalRequestsSchema() | ||
| .sszDeserialize(data.slice(1)) | ||
| .asList()); | ||
| break; | ||
| case ConsolidationRequest.REQUEST_TYPE: | ||
| // https://eips.ethereum.org/EIPS/eip-7251 | ||
| executionRequestsBuilder.consolidations( | ||
| executionRequestsSchema | ||
| .getConsolidationRequestsSchema() | ||
| .sszDeserialize(data.slice(1)) | ||
| .asList()); | ||
| break; |
There was a problem hiding this comment.
nit: new syntax for case statements?
lucassaldanha
force-pushed
the
electra-requests-codec
branch
from
9428759
to
3daf1a8
Compare
StefanBratanov
approved these changes
Oct 8, 2024
lucassaldanha
force-pushed
the
electra-requests-codec
branch
from
2d138c5
to
68567dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Implementing the rules for decoding and hashing execution requests according to ethereum/execution-apis#591
Fixed Issue(s)
part of #8620
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog