Switch to compounding when consolidating with source==target #8646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
reviewed
Sep 26, 2024
| @@ -379,6 +379,23 @@ private void processConsolidationRequest( | |||
| final UInt64 slot = state.getSlot(); | |||
| final UInt64 currentEpoch = miscHelpers.computeEpochAtSlot(slot); | |||
|
|
|||
| if (isValidSwitchToCompoundingRequest(state, consolidationRequest)) { | |||
| LOG.debug("process_consolidation_request: valid switching validator to compounding address"); | |||
There was a problem hiding this comment.
this would probably be more valuable with context, so that we can see the validator id or abbreviated key?
rolfyone
reviewed
Sep 26, 2024
|
|
||
| // Verify that source != target, so a consolidation cannot be used as an exit | ||
| if (consolidationRequest.getSourcePubkey().equals(consolidationRequest.getTargetPubkey())) { | ||
| LOG.debug("process_consolidation_request: source_pubkey and target_pubkey must be different"); |
There was a problem hiding this comment.
probably would add the abbreviated pubkey here too...
lucassaldanha
force-pushed
the
teku-8617
branch
from
d5b03ec
to
99feb8c
Compare
|
Need to wait for #8618 to rebase. |
rolfyone
reviewed
Oct 7, 2024
Comment on lines
+187
to
197
| final byte[] withdrawalCredentialsUpdated = | ||
| state.getValidators().get(index).getWithdrawalCredentials().toArray(); | ||
| withdrawalCredentialsUpdated[0] = COMPOUNDING_WITHDRAWAL_BYTE; | ||
| state | ||
| .getValidators() | ||
| .update( | ||
| index, | ||
| validator -> | ||
| validator.withWithdrawalCredentials(Bytes32.wrap(withdrawalCredentialsUpdated))); | ||
| queueExcessActiveBalance(state, index); | ||
| } |
There was a problem hiding this comment.
nit: probably not super important but this is super unsafe if the index doesn't exist, i wonder if we should put a comment in the description
PRE: validator must exist
It's checked up in the process, but this is also public, and we probably want to be super careful where we attempt this...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixed Issue(s)
fixes #8617
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog