Refactored externalSigner to use Typedefs #8541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created a new suite of tests to show a number of different signing bodies. - had to do manual testing for external signer becuase no AT i think - I was able to get from phase0 -> bellatrix so this should cover most scenarios. - I believe most of the wrappers should be available in the api partially addresses Consensys#8527 Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
...cceptance-test/java/tech/pegasys/teku/test/acceptance/CapellaRemoteSignerAcceptanceTest.java
Outdated
Show resolved
Hide resolved
gfukushima
approved these changes
Sep 5, 2024
...test/java/tech/pegasys/teku/validator/client/signer/ExternalSignerAltairIntegrationTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Harris <[email protected]>
… i cant easily do deserializable type for blockWrapper in this way... Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
validator/api/src/main/java/tech/pegasys/teku/validator/api/signer/BlockWrapper.java
Fixed
Show resolved
Hide resolved
Signed-off-by: Paul Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #8527
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog