Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bridge contract and restaking-v2 audits #4508

Merged
merged 2 commits into from
Sep 11, 2024
Merged

add bridge contract and restaking-v2 audits #4508

merged 2 commits into from
Sep 11, 2024

Conversation

dhruvja
Copy link
Contributor

@dhruvja dhruvja commented Sep 6, 2024

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@dhruvja dhruvja requested a review from JafarAz September 6, 2024 07:14
Copy link

github-actions bot commented Sep 6, 2024

⚠️ Possible file(s) that should be tracked in LFS detected ⚠️

    The following file(s) are tracked in LFS and were likely accidentally checked in:

    audits/solana-bridge-contract/composable_bridge_audit_draft.pdf, audits/solana-restaking-v2/composable_audit_draft_v2.pdf

@github-actions github-actions bot added the lfs-detected! bot: Warning Label for use when LFS is detected in the commits of a Pull Request #owned:terraform label Sep 6, 2024
@Ciejo Ciejo self-requested a review September 9, 2024 12:40
Copy link

github-actions bot commented Sep 9, 2024

⚠️ Possible file(s) that should be tracked in LFS detected ⚠️

    The following file(s) are tracked in LFS and were likely accidentally checked in:

    audits/solana-bridge-contract/composable_bridge_audit_draft.pdf, audits/solana-restaking-v2/composable_audit_draft_v2.pdf

@Ciejo Ciejo merged commit d69900f into main Sep 11, 2024
20 of 23 checks passed
@Ciejo Ciejo deleted the add-solana-audits branch September 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lfs-detected! bot: Warning Label for use when LFS is detected in the commits of a Pull Request #owned:terraform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants