Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(devnets): runtime tests for multihop pallet #4200

Merged
merged 8 commits into from
Oct 20, 2023
Merged

Conversation

kollegian
Copy link
Contributor

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

@github-actions
Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 9 41m 2
RustNinja 8 14h 56m 0
blasrodri 7 18h 49m 6
kkast 6 7h 48m 1
JafarAz 4 37m 1
mina86 3 1d 3h 43m 12
vmarkushin 2 2h 33m 4
0xBrainjar2 2 6h 41m 0
fl-y 1 18h 46m 0
josietyleung 1 26m 0

@github-actions
Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4200/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4200/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4200/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4200/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4200/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@kollegian kollegian added the Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform label Oct 16, 2023
@kollegian kollegian marked this pull request as ready for review October 16, 2023 09:25
dzmitry-lahoda
dzmitry-lahoda previously approved these changes Oct 16, 2023
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

so please write

  1. bash how to run it.
  2. eliminate copy paste.
  3. look at cvm.json - if you are ok with format of config for you.

why?

we need it on CI. but what I sure agains to have brittle tests which slow me down.
so balance for me is - make them non brittle as above.

in general awesome approach as it seem.s

dzmitry-lahoda
dzmitry-lahoda previously approved these changes Oct 17, 2023
@RustNinja RustNinja self-requested a review October 17, 2023 18:40
RustNinja
RustNinja previously approved these changes Oct 17, 2023
@kollegian kollegian changed the title test: multihop tests test: Multihop tests Oct 18, 2023
@vladislav-terzi vladislav-terzi linked an issue Oct 19, 2023 that may be closed by this pull request
@kollegian kollegian changed the title test: Multihop tests test: multihop tests Oct 20, 2023
@kollegian kollegian changed the title test: multihop tests test(devnets): multihop tests Oct 20, 2023
@kollegian kollegian enabled auto-merge (squash) October 20, 2023 10:33
@kollegian kollegian changed the title test(devnets): multihop tests test(devnets): runtime tests for multihop tests Oct 20, 2023
@kollegian kollegian changed the title test(devnets): runtime tests for multihop tests test(devnets): runtime tests for multihop pallet Oct 20, 2023
@kollegian kollegian merged commit f65a0f7 into main Oct 20, 2023
35 checks passed
@kollegian kollegian deleted the tests/multihop-tests branch October 20, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Misc I marked PR by `misc` label if it should not be in release notes #owned:terraform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multihop Auto-tests
3 participants